-
Notifications
You must be signed in to change notification settings - Fork 45
Update sunpy calendar #801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
calendars/sunpy.yaml
Outdated
It is always at 5pm British Time (UTC+1 in the summer, UTC in the winter) on Wednesdays. | ||
begin: 2022-07-20 17:00:00 +00:00 | ||
end: 2022-07-20 18:00:00 +00:00 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how to handle this fact in the calendar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can handle it now, but please do open a feature request for the problem in https://github.com/scientific-python/yaml2ics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, keep it as 16:00 as that will be the UTC for right now (and then in practice we go back and forth between the two time slot)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opened the issue, though I'm not sure if there will be a solution: scientific-python/yaml2ics#121
✅ Deploy Preview for scientific-python-org ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the time back to 16:00 to correspond the UTC value for the summertime call. Otherwise this looks good.
calendars/sunpy.yaml
Outdated
It is always at 5pm British Time (UTC+1 in the summer, UTC in the winter) on Wednesdays. | ||
begin: 2022-07-20 17:00:00 +00:00 | ||
end: 2022-07-20 18:00:00 +00:00 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can handle it now, but please do open a feature request for the problem in https://github.com/scientific-python/yaml2ics
calendars/sunpy.yaml
Outdated
It is always at 5pm British Time (UTC+1 in the summer, UTC in the winter) on Wednesdays. | ||
begin: 2022-07-20 17:00:00 +00:00 | ||
end: 2022-07-20 18:00:00 +00:00 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, keep it as 16:00 as that will be the UTC for right now (and then in practice we go back and forth between the two time slot)
I broke it, please hold. |
OK, I see an error in the build: |
I can just add it back? |
Co-authored-by: Brigitta Sipőcz <b.sipocz@gmail.com>
Co-authored-by: Brigitta Sipőcz <b.sipocz@gmail.com>
Just a few old urls