-
Notifications
You must be signed in to change notification settings - Fork 0
176 demo account #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
176 demo account #159
Conversation
{paragraphs.map((par, index) => ( | ||
<div className={`text-box--${alignment} ${addClass || ''}`} key={index}> | ||
<p | ||
className={`text-box text-box--${size} mb-0`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when we have multiple paragraphs, we want space between them. I initially had a conditional to remove the spacing from the last paragraph only, but felt that was too specific to our current use case. (part of the "about us" section).
in the future, this component could be used anywhere, and having the bottom margin is a good thing.
<> | ||
<Title title='My Requests' size='medium' /> | ||
<div className='rounded overflow-hidden'> | ||
<div className='rounded overflow-hidden mb-4'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adds some spacing between the last item in the list, and the footer.
…ersions of the secondary color. plus formatting in this file
…info" form headers, dynamic
</div> | ||
) | ||
})} | ||
const StatusBar = ({ backgroundColor, statusArray, apiRequestStatus, addClass }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added backgroundColor
import './status-bar.scss' | ||
|
||
const StatusBar = ({ statusArray, apiRequestStatus, addClass }) => ( | ||
<div className={`container ${addClass}`}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the majority of this code is the same. I needed to create a new variable and function though, so the return body is no longer immediately being returned. a lot of this change is adding indention for that reason.
return ( | ||
<div | ||
className={`status-bar-column col-3 py-2 gap-2 d-flex justify-content-center align-items-center | ||
${border} ${labelBgColor(index)}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deriving both of these classes from the new code above.
ref: scientist-hq/webstore#176
expected behavior