Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidekiq is spamming deprecation warnings #88

Closed
2 tasks
kirkkwang opened this issue Aug 23, 2023 · 0 comments
Closed
2 tasks

Sidekiq is spamming deprecation warnings #88

kirkkwang opened this issue Aug 23, 2023 · 0 comments
Assignees
@kirkkwang
Labels
Upgrade Bug
Milestone
Hyrax Upgrade

Comments

@kirkkwang
Copy link

kirkkwang commented Aug 23, 2023 •
edited
Loading

Story

After the upgrade, we are getting spammed with the following deprecation warning:

Passing the timeout as a positional argument is deprecated, it should be passed as a keyword argument:
  redis.brpop("queue:exports", "queue:mailers", "queue:backfill_validations", "queue:default", "queue:import", "queue:ingest", "queue:push_to_aapb", timeout: 2)(called from: /usr/local/bundle/gems/sidekiq-6.4.2/lib/sidekiq/fetch.rb:47:in `block in retrieve_work')

Acceptance Criteria

  • Sidekiq stops spamming deprecation warnings

Testing Instructions and Sample Files

  • In local dev environment, boot up Sidekiq and observe the lack of deprecation warning spams

Notes

Addressed here: sidekiq/sidekiq#5488
Fix is in Sidekiq 6.5.6+
@kirkkwang kirkkwang self-assigned this Aug 23, 2023
kirkkwang added a commit to WGBH-MLA/ams that referenced this issue Aug 23, 2023
@kirkkwang
🧹 Upgrade Sidekiq
d03d650 
This commit will upgrade Sidekiq to 6.5.9 to remove the deprecation
warning spam.

Ref:
  - scientist-softserv#88
@kirkkwang kirkkwang mentioned this issue Aug 23, 2023
Merged
@jillpe jillpe added this to the Hyrax Upgrade milestone Aug 29, 2023
@jillpe jillpe closed this as completed Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirkkwang kirkkwang

Labels
Upgrade Bug
Projects
AMS / GBH
Status: Done
Milestone
Hyrax Upgrade
Development

No branches or pull requests
2 participants
@kirkkwang @jillpe