Fixed issues from SonarQube

app/Exceptions/PermissionConfigurationException.php

@@ -0,0 +1,21 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Exceptions;
+
+use Exception;
+
+class PermissionConfigurationException extends Exception {
+    public static function configNotLoaded(): self {
+        return new self('Error: config/permission.php not loaded. Run [php artisan config:clear] and try again.');
+    }
+
+    public static function teamForeignKeyNotLoaded(): self {
+        return new self('Error: team_foreign_key on config/permission.php not loaded. Run [php artisan config:clear] and try again.');
+    }
+
+    public static function configNotFoundForDown(): self {
+        return new self('Error: config/permission.php not found and defaults could not be merged. Please publish the package configuration before proceeding, or drop the tables manually.');
+    }
+}

app/Http/Middleware/HandleInertiaRequests.php

@@ -20,15 +20,6 @@ class HandleInertiaRequests extends Middleware {
      */
     protected $rootView = 'app';
 
-    /**
-     * Determines the current asset version.
-     *
-     * @see https://inertiajs.com/asset-versioning
-     */
-    public function version(Request $request): ?string {
-        return parent::version($request);
-    }
-
     /**
      * Define the props that are shared by default.
      *

app/Policies/UserPolicy.php

@@ -13,7 +13,7 @@ public function viewAny(User $user): bool {
         return $user->can(PermissionsEnum::VIEW_USERS->value);
     }
 
-    public function view(User $user, User $model): bool {
+    public function view(User $user): bool {
         return $user->can(PermissionsEnum::VIEW_USERS->value);
     }
 
@@ -49,7 +49,7 @@ public function delete(User $user, User $model): bool {
         return $user->can(PermissionsEnum::DELETE_USERS->value);
     }
 
-    public function restore(User $user, User $model): bool {
+    public function restore(User $user): bool {
         return $user->can(PermissionsEnum::RESTORE_USERS->value);
     }
 }

config/database.php

@@ -4,6 +4,8 @@
 
 use Illuminate\Support\Str;
 
+$DEFAULT_HOST = '127.0.0.1';
+
 return [
 
     /*
@@ -47,7 +49,7 @@
         'mysql' => [
             'driver' => 'mysql',
             'url' => env('DB_URL'),
-            'host' => env('DB_HOST', '127.0.0.1'),
+            'host' => env('DB_HOST', $DEFAULT_HOST),
             'port' => env('DB_PORT', '3306'),
             'database' => env('DB_DATABASE', 'laravel'),
             'username' => env('DB_USERNAME', 'root'),
@@ -67,7 +69,7 @@
         'mariadb' => [
             'driver' => 'mariadb',
             'url' => env('DB_URL'),
-            'host' => env('DB_HOST', '127.0.0.1'),
+            'host' => env('DB_HOST', $DEFAULT_HOST),
             'port' => env('DB_PORT', '3306'),
             'database' => env('DB_DATABASE', 'laravel'),
             'username' => env('DB_USERNAME', 'root'),
@@ -87,7 +89,7 @@
         'pgsql' => [
             'driver' => 'pgsql',
             'url' => env('DB_URL'),
-            'host' => env('DB_HOST', '127.0.0.1'),
+            'host' => env('DB_HOST', $DEFAULT_HOST),
             'port' => env('DB_PORT', '5432'),
             'database' => env('DB_DATABASE', 'laravel'),
             'username' => env('DB_USERNAME', 'root'),
@@ -155,7 +157,7 @@
 
         'default' => [
             'url' => env('REDIS_URL'),
-            'host' => env('REDIS_HOST', '127.0.0.1'),
+            'host' => env('REDIS_HOST', $DEFAULT_HOST),
             'username' => env('REDIS_USERNAME'),
             'password' => env('REDIS_PASSWORD'),
             'port' => env('REDIS_PORT', '6379'),
@@ -164,7 +166,7 @@
 
         'cache' => [
             'url' => env('REDIS_URL'),
-            'host' => env('REDIS_HOST', '127.0.0.1'),
+            'host' => env('REDIS_HOST', $DEFAULT_HOST),
             'username' => env('REDIS_USERNAME'),
             'password' => env('REDIS_PASSWORD'),
             'port' => env('REDIS_PORT', '6379'),

config/logging.php

@@ -7,6 +7,8 @@
 use Monolog\Handler\SyslogUdpHandler;
 use Monolog\Processor\PsrLogMessageProcessor;
 
+$DEFAULT_LOG_PATH = 'logs/laravel.log';
+
 return [
 
     /*
@@ -62,14 +64,14 @@
 
         'single' => [
             'driver' => 'single',
-            'path' => storage_path('logs/laravel.log'),
+            'path' => storage_path($DEFAULT_LOG_PATH),
             'level' => env('LOG_LEVEL', 'debug'),
             'replace_placeholders' => true,
         ],
 
         'daily' => [
             'driver' => 'daily',
-            'path' => storage_path('logs/laravel.log'),
+            'path' => storage_path($DEFAULT_LOG_PATH),
             'level' => env('LOG_LEVEL', 'debug'),
             'days' => env('LOG_DAILY_DAYS', 14),
             'replace_placeholders' => true,
@@ -126,7 +128,7 @@
         ],
 
         'emergency' => [
-            'path' => storage_path('logs/laravel.log'),
+            'path' => storage_path($DEFAULT_LOG_PATH),
         ],
 
     ],

database/migrations/2025_03_19_061321_create_permission_tables.php

@@ -1,5 +1,6 @@
 <?php
 
+use App\Exceptions\PermissionConfigurationException;
 use Illuminate\Database\Migrations\Migration;
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
@@ -8,6 +9,7 @@
     /**
      * Run the migrations.
      */
+    // NOSONAR
     public function up(): void {
         $teams = config('permission.teams');
         $tableNames = config('permission.table_names');
@@ -16,10 +18,10 @@ public function up(): void {
         $pivotPermission = $columnNames['permission_pivot_key'] ?? 'permission_id';
 
         if (empty($tableNames)) {
-            throw new \Exception('Error: config/permission.php not loaded. Run [php artisan config:clear] and try again.');
+            throw PermissionConfigurationException::configNotLoaded();
         }
         if ($teams && empty($columnNames['team_foreign_key'] ?? null)) {
-            throw new \Exception('Error: team_foreign_key on config/permission.php not loaded. Run [php artisan config:clear] and try again.');
+            throw PermissionConfigurationException::teamForeignKeyNotLoaded();
         }
 
         Schema::create($tableNames['permissions'], static function (Blueprint $table) {
@@ -132,7 +134,7 @@ public function down(): void {
         $tableNames = config('permission.table_names');
 
         if (empty($tableNames)) {
-            throw new \Exception('Error: config/permission.php not found and defaults could not be merged. Please publish the package configuration before proceeding, or drop the tables manually.');
+            throw PermissionConfigurationException::configNotFoundForDown();
         }
 
         Schema::drop($tableNames['role_has_permissions']);

database/seeders/RolesAndPermissionsSeeder.php

@@ -34,7 +34,7 @@ public function run(): void {
         // create roles using RolesEnum
         $admin_role = Role::firstOrCreate(['name' => RolesEnum::ADMINISTRATOR->value, 'guard_name' => 'web']);
         $user_manager_role = Role::firstOrCreate(['name' => RolesEnum::USER_MANAGER->value, 'guard_name' => 'web']);
-        $registered_user_role = Role::firstOrCreate(['name' => RolesEnum::REGISTERED_USER->value, 'guard_name' => 'web']);
+        Role::firstOrCreate(['name' => RolesEnum::REGISTERED_USER->value, 'guard_name' => 'web']);
         // flush cache after creating roles and permissions
         app()[\Spatie\Permission\PermissionRegistrar::class]->forgetCachedPermissions();
 

resources/js/app.tsx

@@ -5,7 +5,7 @@ import { createRoot } from 'react-dom/client';
 import { initializeTheme } from './hooks/use-appearance';
 
 // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
-const appName = import.meta.env.VITE_APP_NAME || 'Laravel';
+const appName = import.meta.env.VITE_APP_NAME ?? 'Laravel';
 
 createInertiaApp({
 	title: (title) => `${title} - ${appName}`,

resources/js/components/app-content.tsx

@@ -5,7 +5,7 @@ interface AppContentProps extends React.ComponentProps<'main'> {
 	variant?: 'header' | 'sidebar';
 }
 
-export function AppContent({ variant = 'header', children, ...props }: AppContentProps) {
+export function AppContent({ variant = 'header', children, ...props }: Readonly<AppContentProps>) {
 	if (variant === 'sidebar') {
 		return <SidebarInset {...props}>{children}</SidebarInset>;
 	}

resources/js/components/app-header.tsx

@@ -52,7 +52,7 @@ interface AppHeaderProps {
 	breadcrumbs?: BreadcrumbItem[];
 }
 
-export function AppHeader({ breadcrumbs = [] }: AppHeaderProps) {
+export function AppHeader({ breadcrumbs = [] }: Readonly<AppHeaderProps>) {
 	const page = usePage<SharedData>();
 	const { auth } = page.props;
 	const getInitials = useInitials();
@@ -136,9 +136,9 @@ export function AppHeader({ breadcrumbs = [] }: AppHeaderProps) {
 					<div className="ml-6 hidden h-full items-center space-x-6 lg:flex">
 						<NavigationMenu className="flex h-full items-stretch">
 							<NavigationMenuList className="flex h-full items-stretch space-x-2">
-								{mainNavItems.map((item, index) => (
+								{mainNavItems.map((item) => (
 									<NavigationMenuItem
-										key={index}
+										key={item.href || item.title}
 										className="relative flex h-full items-center"
 									>
 										<Link

resources/js/components/app-logo-icon.tsx

@@ -6,7 +6,7 @@ export default function AppLogoIcon(props: ImgHTMLAttributes<HTMLImageElement>)
 			{...props}
 			src="/images/logo.png"
 			alt="App Logo"
-			className={`w-auto ${props.className || ''}`}
+			className={`w-auto ${props.className ?? ''}`}
 		/>
 	);
 }

resources/js/components/app-shell.tsx

@@ -6,7 +6,7 @@ interface AppShellProps {
 	variant?: 'header' | 'sidebar';
 }
 
-export function AppShell({ children, variant = 'header' }: AppShellProps) {
+export function AppShell({ children, variant = 'header' }: Readonly<AppShellProps>) {
 	const [isOpen, setIsOpen] = useState(() =>
 		typeof window !== 'undefined' ? localStorage.getItem('sidebar') !== 'false' : true
 	);

resources/js/components/app-sidebar-header.tsx

@@ -2,7 +2,9 @@ import { Breadcrumbs } from '@/components/breadcrumbs';
 import { SidebarTrigger } from '@/components/ui/sidebar';
 import { type BreadcrumbItem as BreadcrumbItemType } from '@/types';
 
-export function AppSidebarHeader({ breadcrumbs = [] }: { breadcrumbs?: BreadcrumbItemType[] }) {
+export function AppSidebarHeader({
+	breadcrumbs = [],
+}: Readonly<{ breadcrumbs?: BreadcrumbItemType[] }>) {
 	return (
 		<header className="border-sidebar-border/50 group-has-data-[collapsible=icon]/sidebar-wrapper:h-12 flex h-16 shrink-0 items-center gap-2 border-b px-6 transition-[width,height] ease-linear md:px-4">
 			<div className="flex items-center gap-2">

resources/js/components/breadcrumbs.tsx

@@ -10,7 +10,7 @@ import { type BreadcrumbItem as BreadcrumbItemType } from '@/types';
 import { Link } from '@inertiajs/react';
 import { Fragment } from 'react';
 
-export function Breadcrumbs({ breadcrumbs }: { breadcrumbs: BreadcrumbItemType[] }) {
+export function Breadcrumbs({ breadcrumbs }: Readonly<{ breadcrumbs: BreadcrumbItemType[] }>) {
 	return (
 		<>
 			{breadcrumbs.length > 0 && (

resources/js/components/heading-small.tsx

@@ -1,10 +1,10 @@
 export default function HeadingSmall({
 	title,
 	description,
-}: {
+}: Readonly<{
 	title: string;
 	description?: string;
-}) {
+}>) {
 	return (
 		<header>
 			<h3 className="mb-0.5 text-base font-medium">{title}</h3>

resources/js/components/heading.tsx

@@ -1,4 +1,7 @@
-export default function Heading({ title, description }: { title: string; description?: string }) {
+export default function Heading({
+	title,
+	description,
+}: Readonly<{ title: string; description?: string }>) {
 	return (
 		<div className="mb-8 space-y-0.5">
 			<h2 className="text-xl font-semibold tracking-tight">{title}</h2>

resources/js/components/icon.tsx

@@ -6,6 +6,6 @@ interface IconProps extends Omit<LucideProps, 'ref'> {
 	iconNode: ComponentType<LucideProps>;
 }
 
-export function Icon({ iconNode: IconComponent, className, ...props }: IconProps) {
+export function Icon({ iconNode: IconComponent, className, ...props }: Readonly<IconProps>) {
 	return <IconComponent className={cn('h-4 w-4', className)} {...props} />;
 }

resources/js/components/nav-footer.tsx

@@ -17,7 +17,7 @@ export function NavFooter({
 	items: NavItem[];
 }) {
 	return (
-		<SidebarGroup {...props} className={`group-data-[collapsible=icon]:p-0 ${className || ''}`}>
+		<SidebarGroup {...props} className={`group-data-[collapsible=icon]:p-0 ${className ?? ''}`}>
 			<SidebarGroupContent>
 				<SidebarMenu>
 					{items.map((item) => (