Asynchronous status reporting - keeps workers from blocking on UI status reporting #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdezonia
added a commit
that referenced
this pull request
Oct 7, 2013
Asynchronous status reporting - keeps workers from blocking on UI status reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all, this is a proposed change that makes the default status service use asynchronous messaging for status events. I experienced a deadlock when a worker thread reported a status after grabbing a lock while the UI thread was repainting. The UI thread blocked when it tried to get the worker thread's locked object and ImageJ deadlocked because the worker thread blocked while waiting for the status event to be handled by the UI thread.
This limits the problem somewhat.