Skip to content

Adds method to get InputWidget from InputPanel #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2016
Merged

Conversation

dietzc
Copy link
Contributor

@dietzc dietzc commented Jul 12, 2016

sometimes one wants to access the InputWidget from InputPanels directly. Therefore one can request now the InputWidgetfrom an InputPanel. However, this breaks backwards compatibility.

@ctrueden ctrueden merged commit c0307a2 into master Jul 12, 2016
@ctrueden ctrueden deleted the inputwidgets branch July 12, 2016 15:30
@ctrueden
Copy link
Member

Thanks! 😄

@ctrueden
Copy link
Member

Regarding backwards compatibility: no problem, because the abstract class offers the implementation. Our policy in SJC is that new interface methods can be added, as long as the corresponding abstract class (or the interface itself, thanks to Java 8 default methods) provides a default implementation. See also http://imagej.net/Versioning#Scope_of_SemVer, where we actually do not promise even that—we guarantee only API compatibility, not SPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants