Adds method to get InputWidget from InputPanel #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! 😄 |
|
Regarding backwards compatibility: no problem, because the abstract class offers the implementation. Our policy in SJC is that new interface methods can be added, as long as the corresponding abstract class (or the interface itself, thanks to Java 8 default methods) provides a default implementation. See also http://imagej.net/Versioning#Scope_of_SemVer, where we actually do not promise even that—we guarantee only API compatibility, not SPI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sometimes one wants to access the
InputWidgetfromInputPanels directly. Therefore one can request now theInputWidgetfrom anInputPanel. However, this breaks backwards compatibility.