Skip to content

Fix priority of LoggerPreprocessor #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2022
Merged

Fix priority of LoggerPreprocessor #447

merged 1 commit into from
Dec 12, 2022

Conversation

imagejan
Copy link
Member

Logger parameters should be processed before InitPreprocessor, so that plugins can use a Logger in their initializer.

Closes #446.

@imagejan
Fix priority of LoggerPreprocessor
918d915 
Logger parameters should be processed before InitPreprocessor, so that plugins can use a Logger in their initializer.
@imagejan imagejan requested a review from ctrueden December 12, 2022 14:01
@ctrueden
Copy link
Member

@imagejan Thanks! So the change to VERY_HIGH ends up moving the LoggerPreprocessor to before the InitPreprocessor (which is HIGH) but still after the ServicePreprocessor (which is 2*VERY_HIGH). That's intended, right?

@ctrueden ctrueden merged commit 9564503 into master Dec 12, 2022
@ctrueden ctrueden deleted the loggerpreprocessor-priority branch December 12, 2022 16:30
@imagejan
Copy link
Member Author

Thanks for merging, @ctrueden!
Exactly, moving LoggerPreprocessor priority in between ServicePreprocessor and InitPreprocessor was intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrueden ctrueden Awaiting requested review from ctrueden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logger parameters can't be used while initializing DynamicCommands
2 participants
@imagejan @ctrueden