Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust fonts of the screen and error window when adjusting the editor's font #26

Merged
merged 2 commits into from Nov 7, 2018

Conversation

Projects
None yet
3 participants
@acardona
Copy link
Contributor

acardona commented Nov 3, 2018

Until this commit, the font of the screen (the lower part) was not adjusted when adjusting the font of the editor pane (the upper part). With this commit, it does.

@acardona

This comment has been minimized.

Copy link
Contributor Author

acardona commented Nov 3, 2018

By the way, I wrote a good part of the Script Editor code. I find it strange that it is not credited to me in the scijava repository: like it was copy pasted and committed by someone else at some point, when split from the main Fiji repository.

Also it would be nice to have committer rights to fix my own broken code.

@imagejan

This comment has been minimized.

Copy link
Member

imagejan commented Nov 3, 2018

@acardona looking back in the commit history of this repository, there's a substantial number of commits by yourself in the 2010/2011 range. Could you point to some place where you're not credited appropriately, so that it can be fixed?

Also it would be nice to have committer rights to fix my own broken code.

As far as I understand the SciJava Governance, push permission to the repository should be granted to all who actively maintain the project and take over responsibility for fixing issues etc. If you're willing to take over some of the roles {Developer, Debugger, Maintainer}, I'm sure you will be happily granted committer rights.

@imagejan

This comment has been minimized.

Copy link
Member

imagejan commented Nov 3, 2018

I checked out and tested these changes on Mac OSX. Everything works as advertised and is good to merge, in my opinion. Thanks for the fixes, @acardona.

@acardona

This comment has been minimized.

Copy link
Contributor Author

acardona commented Nov 4, 2018

@acardona

This comment has been minimized.

Copy link
Contributor Author

acardona commented Nov 4, 2018

@acardona

This comment has been minimized.

Copy link
Contributor Author

acardona commented Nov 6, 2018

If tests pass, and @imagejan tested the changes and it works for him too, please can this PR be merged.

@@ -2454,4 +2453,15 @@ public void changedUpdate(final DocumentEvent e) {
setTitle();
}

public void setFontSize(final float size) {

This comment has been minimized.

@imagejan

imagejan Nov 6, 2018

Member

Since the public API changed, I suggest that the version of this component be updated to 0.4.0-SNAPSHOT in pom.xml.

POM: bump minor version
There is new public API.

@ctrueden ctrueden merged commit 4e67595 into scijava:master Nov 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ctrueden

This comment has been minimized.

Copy link
Member

ctrueden commented Nov 7, 2018

Thanks for the patch, @acardona! Thanks for testing, @imagejan!

I added 92128e4 which bumps the version to 0.4.0-SNAPSHOT, since there is new public API.

@acardona @imagejan I added you two as collaborators to this repository. (No one had been added yet, since it was relatively new.) Please let me know which SciJava team roles you can commit to regarding this project, and I'll update the info in the POM accordingly.

@ctrueden

This comment has been minimized.

Copy link
Member

ctrueden commented Nov 7, 2018

This page misled me, as it doesn't list neither the Google Summer of code student that wrote a lot of the Script Editor code, nor myself: https://github.com/scijava/script-editor/graphs/contributors

@acardona I think that is due to the email addresses used. If you do git shortlog -nse you'll see that your gmail address has only 1 commit, whereas the rest were done under different emails. I bet if you add your other email addresses (particularly the ethz.ch address) on GitHub, it will start counting your statistics better.

By the way: regarding giving credit where credit is due: I have been working for a long time on autogenerating wiki sidebars from the pom.xml metadata. You can see the result for the Script Editor here: https://imagej.net/Template:ComponentStats:org.scijava:script-editor. There are still a couple of rough edges:

  • I am listed as a co-"founder" for the script-editor because I created the scijava/script-editor GitHub repository. But of course I did not start the original Fiji Script Editor project. I pushed a95ee5e to address this, but the wiki templates have not been updated in a while.
  • The "Project" for script-editor is listed as ImageJ, but should say SciJava.
  • The wiki templates are currently only generated manually (by this code). Eventually I want to automate it, so the sidebars stay up to date with new ImageJ+Fiji component roll-outs.
  • The sidebar is a bit large; I'd like to find ways to trim it down, while still reporting all the information there somehow. Suggestions welcome.
@acardona

This comment has been minimized.

Copy link
Contributor Author

acardona commented Nov 8, 2018

Hi @ctrueden , I could take the "Developer" role for this project.

On the ethz.ch email: I can no longer access it, so I can't verify it. Such is the nature of academic emails. Hence I use my gmail as much as I can for git repositories.

On 92128e4, is the POM update done automatically with a script, or do you manually edit the XML files? Is the manual on POMs current?

ctrueden added a commit that referenced this pull request Mar 14, 2019

@ctrueden

This comment has been minimized.

Copy link
Member

ctrueden commented Mar 14, 2019

I could take the "Developer" role for this project.

Sounds good. Apologies for the long delay. Done in 59b9054.

Keep in mind that means that if someone on the forum requests a new Script Editor feature, you are broadcasting that you will consider implementing it as your time allows. But since you are not taking the support or reviewer roles, you are broadcasting that you typically won't respond to Script Editor questions on the forum, nor to pull requests submitted to the repository. Was that your intent?

On 92128e4, is the POM update done automatically with a script, or do you manually edit the XML files?

I always edit POMs manually, or via sed or similar shell scripting techniques. There is no automated tooling because the POMs are the source of the metadata. All the tooling is downstream from the POMs, consuming them to generate more things.

Is the manual on POMs current?

The closest thing we have to a manual is the pom-scijava-base README. The information there is accurate and current, but probably not really an introductory guide.

@acardona

This comment has been minimized.

Copy link
Contributor Author

acardona commented Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.