Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add toy sampling #558

Conversation

lukasheinrich
Copy link
Contributor

@lukasheinrich lukasheinrich commented Sep 9, 2019

Description

toys

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Add toy sampling capability
* Remove projection methods from constraint
* Add generalized tensorviewer (expect to merge w/ ParamViewer)
* Introduce make_pdf method to construct pdf with frozen parameters, evaluate with log_prob
* Add Poisson and Normal classes to Numpy backend with same API as PyTorch/Tensorflow

@coveralls
Copy link

coveralls commented Sep 9, 2019

Coverage Status

Coverage increased (+0.1%) to 93.586% when pulling a86e8fc on add_probability_module_withjoint_withextended_pdf_api_withtoys into b8f524a on master.

@lukasheinrich lukasheinrich changed the title [WIP] Towards statisfactory .. toys edition Towards statisfactory .. toys edition Sep 9, 2019
@matthewfeickert
Copy link
Member

I migrated docstrings from PR #551, but I'll come back to this later.

@matthewfeickert matthewfeickert mentioned this pull request Sep 9, 2019
4 tasks
@matthewfeickert matthewfeickert force-pushed the add_probability_module_withjoint_withextended_pdf_api_withtoys branch from 6a9b1aa to ed520e5 Compare September 9, 2019 20:29
@matthewfeickert matthewfeickert mentioned this pull request Sep 10, 2019
41 tasks
@lukasheinrich lukasheinrich changed the title Towards statisfactory .. toys edition Towards pyfitcore .. toys edition Sep 12, 2019
@lukasheinrich lukasheinrich force-pushed the add_probability_module_withjoint_withextended_pdf_api branch from d01d91e to 19661a5 Compare September 16, 2019 19:13
@lukasheinrich lukasheinrich force-pushed the add_probability_module_withjoint_withextended_pdf_api_withtoys branch from ed520e5 to 8e30efe Compare September 16, 2019 19:14
@lukasheinrich lukasheinrich force-pushed the add_probability_module_withjoint_withextended_pdf_api branch from 19661a5 to b3bd16a Compare September 17, 2019 23:15
@lukasheinrich lukasheinrich force-pushed the add_probability_module_withjoint_withextended_pdf_api_withtoys branch from 8e30efe to 07e354f Compare September 26, 2019 08:47
@lukasheinrich lukasheinrich changed the base branch from add_probability_module_withjoint_withextended_pdf_api to master September 26, 2019 08:52
@lukasheinrich lukasheinrich changed the title Towards pyfitcore .. toys edition feat: add toy sampling Sep 26, 2019
@lukasheinrich lukasheinrich force-pushed the add_probability_module_withjoint_withextended_pdf_api_withtoys branch from 3829f57 to 732c8ca Compare September 26, 2019 09:00
@lgtm-com
Copy link

lgtm-com bot commented Sep 26, 2019

This pull request introduces 1 alert when merging 316a936 into 3206e97 - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

@lgtm-com
Copy link

lgtm-com bot commented Sep 26, 2019

This pull request introduces 2 alerts when merging 5af5af1 into 3206e97 - view on LGTM.com

new alerts:

  • 2 for Comparison using is when operands support __eq__

@matthewfeickert matthewfeickert force-pushed the add_probability_module_withjoint_withextended_pdf_api_withtoys branch from e880886 to 97d03ae Compare September 28, 2019 17:11
Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukasheinrich Thank you for this awesome PR and for all the work and PRs that you did leading up to this. Everything LGTM and once the CI passes I'll happily merge this in. :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants