Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursively fix forms for objects that require ak.from_iter #441

Merged
merged 2 commits into from
Sep 18, 2021

Conversation

nsmith-
Copy link
Collaborator

@nsmith- nsmith- commented Sep 16, 2021

If a sub-branch cannot be optimized by awkward, the parent cannot either and must have its form fixed for use with lazy arrays.

@nsmith-
Copy link
Collaborator Author

nsmith- commented Sep 16, 2021

Also by mistake I added the fix to TRefArray member refs, which should be a ListArray.

nsmith- added a commit to kratsg/coffea that referenced this pull request Sep 16, 2021
@jpivarski
Copy link
Member

Merging because all looks good and this is a blocker.

(Note for posterity: @nsmith- and I talked about these issues on Slack while he was discovering them.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants