Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement regular array support for TClonesArray #442

Merged
merged 4 commits into from
Sep 20, 2021

Conversation

nsmith-
Copy link
Collaborator

@nsmith- nsmith- commented Sep 17, 2021

No description provided.

nsmith- added a commit to nsmith-/scikit-hep-testdata that referenced this pull request Sep 17, 2021
@nsmith-
Copy link
Collaborator Author

nsmith- commented Sep 17, 2021

The test will require merging scikit-hep/scikit-hep-testdata#65

@nsmith-
Copy link
Collaborator Author

nsmith- commented Sep 17, 2021

This will have issues with delphes_tree["GenJet04/GenJet04.Constituents"].array(library="np") once #441 is merged, need to look a bit more

jpivarski pushed a commit to scikit-hep/scikit-hep-testdata that referenced this pull request Sep 18, 2021
@jpivarski
Copy link
Member

The test will require merging scikit-hep/scikit-hep-testdata#65

See

https://github.com/scikit-hep/scikit-hep-testdata/actions/runs/1247612638

to file the progress of releasing 0.4.8.

@jpivarski
Copy link
Member

jpivarski commented Sep 18, 2021

And ping me again when you're ready for this to be merged. (The changes so far look good.)

@lgray
Copy link
Contributor

lgray commented Sep 18, 2021

@jpivarski that CI run failed looking at the link!

@nsmith-
Copy link
Collaborator Author

nsmith- commented Sep 20, 2021

Actually the problem was much more subtle: essentially by chance the data was such that numpy converted a list of TRefArrays with the same number of refs into a 2D array. This is because by default:

>>> numpy.array([ [1,2], [3,4] ], dtype=object)
array([[1, 2],
       [3, 4]], dtype=object)

nsmith- added a commit to kratsg/coffea that referenced this pull request Sep 20, 2021
@nsmith-
Copy link
Collaborator Author

nsmith- commented Sep 20, 2021

@jpivarski this is ready

@jpivarski jpivarski merged commit 007b100 into scikit-hep:main Sep 20, 2021
@nsmith- nsmith- deleted the regular-tclones branch September 20, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants