-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency #280
Dependency #280
Conversation
Codecov ReportBase: 81.08% // Head: 81.08% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
=======================================
Coverage 81.08% 81.08%
=======================================
Files 96 96
Lines 10672 10672
=======================================
Hits 8653 8653
Misses 2019 2019 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Naman-Priyadarshi! We should also -
- add this to
dev
dependencies - update the section on testing in
contributing.md
to reflect notebook tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Naman-Priyadarshi! Could you also add something like - "To skip the notebook tests, use `--ignore=tests/test_notebooks.py." below -
Running tests locally
The tests can be executed using the test
and test-extras
dependencies of vector
in the following way -
python -m pytest
.github/CONTRIBUTING.md
Outdated
@@ -122,6 +122,14 @@ xdoctest ./src/vector/ | |||
|
|||
A much more detailed guide on testing with `pytest` for `Scikit-HEP` packages is available [here](https://scikit-hep.org/developer/pytest). | |||
|
|||
### Running doctests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Running doctests | |
### Running notebook tests |
Description
Kindly take a look at CONTRIBUTING.md.
I was working on another issue when i found out that papermill (tool for parameterizing and executing Jupyter Notebooks) was missing during pytest. The module is used in the notebook.yml workflow file.
Checklist
$ pre-commit run --all-files
or$ nox -s lint
)$ pytest
or$ nox -s tests
)$ cd docs; make clean; make html
or$ nox -s docs
)$ xdoctest ./src/vector
or$ nox -s doctests
)Before Merging