Skip to content

Conversation

glemaitre
Copy link
Member

@glemaitre glemaitre commented Aug 8, 2016

We were not selecting the samples from the good array.

I change this and enforce that any other implementation using the _selection_dist_based function is doing so. However, we cannot test this case since this is a class method.

@coveralls
Copy link

coveralls commented Aug 8, 2016

Coverage Status

Coverage decreased (-0.03%) to 98.025% when pulling bddb621 on glemaitre:issue_124 into 19969f6 on scikit-learn-contrib:master.

@chkoar chkoar merged commit 23f1ffc into scikit-learn-contrib:master Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants