Skip to content

[MRG] Remove useless code in SMOTE_ENN #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[MRG] Remove useless code in SMOTE_ENN #179

wants to merge 2 commits into from

Conversation

Linkid
Copy link
Contributor

@Linkid Linkid commented Oct 28, 2016

Remove the already declared warning, as stated in issue #173, plus replace a size_ngh variable by its successor n_neighbors.

Linkid added 2 commits October 28, 2016 23:33
@Linkid
Remove useless code in SMOTE_ENN
2742dfa 
The `size_ngh` deprecation warning is already declared in the
`SamplerMixin` class.

Ref scikit-learn-contrib#173
@Linkid
Replace a size_ngh deprecated variable
c66c35b
@coveralls
Copy link

coveralls commented Oct 28, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.001%) to 98.942% when pulling c66c35b on Linkid:remove_useless_code into 3ee7147 on scikit-learn-contrib:master.

@glemaitre
Copy link
Member

Thanks, I think this is all addressed in #177 . I forgot to recall the the issue in the PR. Sorry for that.

@chkoar chkoar closed this Oct 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Linkid @coveralls @glemaitre @chkoar