Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeighbourhoodCleaningRule fix #230

Merged
merged 6 commits into from Feb 7, 2017
Merged

Conversation

@loskutyan
Copy link
Contributor

@loskutyan loskutyan commented Feb 7, 2017

Fixed: for misclassified positive samples they are returned themselves but not their negative neighbours (so behaviour for positive result of IF statement is wrong). #227

@coveralls
Copy link

@coveralls coveralls commented Feb 7, 2017

Coverage Status

Coverage remained the same at 98.934% when pulling e0c8d35 on loskutyan:ncl_fixes into 079dc44 on scikit-learn-contrib:master.

Loading

@glemaitre
Copy link
Member

@glemaitre glemaitre commented Feb 7, 2017

Can you check the PEP8. It seems that you have a line larger than 79 characters.

Loading

@glemaitre
Copy link
Member

@glemaitre glemaitre commented Feb 7, 2017

Also you need to add your contribution in the log, under Bug Fixes

https://raw.githubusercontent.com/scikit-learn-contrib/imbalanced-learn/master/doc/whats_new.rst

Loading

@coveralls
Copy link

@coveralls coveralls commented Feb 7, 2017

Coverage Status

Coverage remained the same at 98.934% when pulling a9276ad on loskutyan:ncl_fixes into 079dc44 on scikit-learn-contrib:master.

Loading

@coveralls
Copy link

@coveralls coveralls commented Feb 7, 2017

Coverage Status

Coverage decreased (-0.05%) to 98.883% when pulling c0c0ada on loskutyan:ncl_fixes into 079dc44 on scikit-learn-contrib:master.

Loading

@coveralls
Copy link

@coveralls coveralls commented Feb 7, 2017

Coverage Status

Coverage remained the same at 98.934% when pulling d1f1fc4 on loskutyan:ncl_fixes into 079dc44 on scikit-learn-contrib:master.

Loading

@glemaitre glemaitre merged commit 4e885ae into scikit-learn-contrib:master Feb 7, 2017
3 checks passed
Loading
@glemaitre
Copy link
Member

@glemaitre glemaitre commented Feb 7, 2017

thanks 👍

Loading

christophe-rannou pushed a commit to christophe-rannou/imbalanced-learn that referenced this issue Apr 3, 2017
…kit-learn-contrib#230)

* main fix: selecting neighbours instead of minority class misclassified samples

* tests fix: 5-th sample additionally removed by new (fixed) rule

* docstring fix: 2 more example samples removed by new (fixed) rule

* fixed too long line

* changelog

* changelog: target name added
glemaitre added a commit to glemaitre/imbalanced-learn that referenced this issue Jun 15, 2017
…kit-learn-contrib#230)

* main fix: selecting neighbours instead of minority class misclassified samples

* tests fix: 5-th sample additionally removed by new (fixed) rule

* docstring fix: 2 more example samples removed by new (fixed) rule

* fixed too long line

* changelog

* changelog: target name added
glemaitre added a commit to glemaitre/imbalanced-learn that referenced this issue Jun 15, 2017
…kit-learn-contrib#230)

* main fix: selecting neighbours instead of minority class misclassified samples

* tests fix: 5-th sample additionally removed by new (fixed) rule

* docstring fix: 2 more example samples removed by new (fixed) rule

* fixed too long line

* changelog

* changelog: target name added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants