[MRG] Correcting EasyEnsemble doc #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In EasyEnsemble doc page, its signature is > class imblearn.ensemble.EasyEnsemble(ratio='auto', return_indices=False, random_state=None, replacement=False, n_subsets=10) with `return_indices=False`, but its pydoc says > return_indices : bool, optional (default=True) > >Whether or not to return the indices of the samples randomly selected from the majority class. Checking the code at https://github.com/scikit-learn-contrib/imbalanced-learn/blob/b45a3e4167d188ec9fd40afd3a56330aa80a5ee1/imblearn/ensemble/easy_ensemble.py#L92, the correct value is False.
|
Thanks |
christophe-rannou
pushed a commit
to christophe-rannou/imbalanced-learn
that referenced
this pull request
Apr 3, 2017
In EasyEnsemble doc page, its signature is > class imblearn.ensemble.EasyEnsemble(ratio='auto', return_indices=False, random_state=None, replacement=False, n_subsets=10) with `return_indices=False`, but its pydoc says > return_indices : bool, optional (default=True) > >Whether or not to return the indices of the samples randomly selected from the majority class. Checking the code at https://github.com/scikit-learn-contrib/imbalanced-learn/blob/b45a3e4167d188ec9fd40afd3a56330aa80a5ee1/imblearn/ensemble/easy_ensemble.py#L92, the correct value is False.
glemaitre
pushed a commit
to glemaitre/imbalanced-learn
that referenced
this pull request
Jun 15, 2017
In EasyEnsemble doc page, its signature is > class imblearn.ensemble.EasyEnsemble(ratio='auto', return_indices=False, random_state=None, replacement=False, n_subsets=10) with `return_indices=False`, but its pydoc says > return_indices : bool, optional (default=True) > >Whether or not to return the indices of the samples randomly selected from the majority class. Checking the code at https://github.com/scikit-learn-contrib/imbalanced-learn/blob/b45a3e4167d188ec9fd40afd3a56330aa80a5ee1/imblearn/ensemble/easy_ensemble.py#L92, the correct value is False.
glemaitre
pushed a commit
to glemaitre/imbalanced-learn
that referenced
this pull request
Jun 15, 2017
In EasyEnsemble doc page, its signature is > class imblearn.ensemble.EasyEnsemble(ratio='auto', return_indices=False, random_state=None, replacement=False, n_subsets=10) with `return_indices=False`, but its pydoc says > return_indices : bool, optional (default=True) > >Whether or not to return the indices of the samples randomly selected from the majority class. Checking the code at https://github.com/scikit-learn-contrib/imbalanced-learn/blob/b45a3e4167d188ec9fd40afd3a56330aa80a5ee1/imblearn/ensemble/easy_ensemble.py#L92, the correct value is False.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In EasyEnsemble doc page, its signature is
with
return_indices=False, but its pydoc saysChecking the code at
imbalanced-learn/imblearn/ensemble/easy_ensemble.py
Line 92 in b45a3e4
Reference Issue
What does this implement/fix? Explain your changes.
Any other comments?