Skip to content

FIX: SMOTENC should use half of the median of the std. dev. #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2018
Merged

FIX: SMOTENC should use half of the median of the std. dev. #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions doc/whats_new/v0.0.4.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,19 @@
.. _changes_0_4:

Version 0.4.2
=============

Changelog
---------

Bug fixes
.........

- Fix a bug in :class:`imblearn.over_sampling.SMOTENC` in which the the median
of the standard deviation instead of half of the median of the standard
deviation.
By :user:`Guillaume Lemaitre <glemaitre>` in :issue:`491`.

Version 0.4
===========

Expand Down
2 changes: 1 addition & 1 deletion imblearn/over_sampling/_smote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -974,7 +974,7 @@ def _fit_resample(self, X, y):
# distance is computed between 2 samples, the difference will be equal
# to the median of the standard deviation as in the original paper.
X_ohe.data = (np.ones_like(X_ohe.data, dtype=X_ohe.dtype) *
self.median_std_)
self.median_std_ / 2)
X_encoded = sparse.hstack((X_continuous, X_ohe), format='csr')

X_resampled, y_resampled = super(SMOTENC, self)._fit_resample(
Expand Down