This repository was archived by the owner on Dec 6, 2023. It is now read-only.
Remove naked mallocs and use cython.cvarray +refcounting #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vene
changed the title
|
Merged by rebase in 8a4b483. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disadvantage:
. This change brings back numpy headers into the cython files. (Might impact build time, maybe just less elegant and unnecessary.))Not anymore; switched to
cython.memoryview.array.Advantages:
. no risk of leaks
. more readable code
No performance regression.
To remove the numpy header import, I could replace the np.empty allocations with cpython.array allocations. Those are much less readable but slightly faster. It has no impact, though, since all allocations are now completely outside of any loops.