Skip to content

Interview with Meekail Zain #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 2, 2022
Merged

Interview with Meekail Zain #151

merged 8 commits into from
Dec 2, 2022

Conversation

SangamSwadiK
Copy link
Contributor

@SangamSwadiK SangamSwadiK commented Nov 30, 2022

closes: #146

@reshamas
Please let me know in case of improvements and fixes or change the text in the poster.
I've tested the blog locally as well.

Thanks!

@SangamSwadiK
Copy link
Contributor Author

Hi, I think I've fixed the spacing issues and links.

Thanks!

@reshamas
Copy link
Member

reshamas commented Dec 2, 2022

@SangamSwadiK Thanks for the PR! It looks very good.

@Micky774 Would you like to review one last time before I merge in?
Unfortunately, we don't have Netlify set up for this blog, so we can't see the preview in full.
It's a very nice interview!

@Micky774
Copy link

Micky774 commented Dec 2, 2022

@SangamSwadiK Thanks for the PR! It looks very good.

@Micky774 Would you like to review one last time before I merge in? Unfortunately, we don't have Netlify set up for this blog, so we can't see the preview in full. It's a very nice interview!

Looks good from what I can see, thanks! Just to make sure though, is the numbering meant to be all 1. rather than 1, 2, 3...? But content wise everything is good :)

@reshamas
Copy link
Member

reshamas commented Dec 2, 2022

@Micky774 Would you like to review one last time before I merge in? Unfortunately, we don't have Netlify set up for this blog, so we can't see the preview in full. It's a very nice interview!

Looks good from what I can see, thanks! Just to make sure though, is the numbering meant to be all 1. rather than 1, 2, 3...? But content wise everything is good :)

@Micky774 The hope is that it will automatically number itself (as Markdown), but sometimes it gets finicky. For example, if we insert an image in the middle of the text, it will reset the numbering to 1. Let's see how it goes.

@reshamas reshamas merged commit 42376b5 into scikit-learn:main Dec 2, 2022
@reshamas
Copy link
Member

reshamas commented Dec 2, 2022

@Micky774
Here it is. If you find there need to be any updates, we can submit an updated PR:
https://blog.scikit-learn.org/team/meekail-zain-interview/

@SangamSwadiK Thanks for the PR!

@Micky774
Copy link

Micky774 commented Dec 2, 2022

@reshamas Actually I think the answer to the second question is someone elses, and not mine. Sorry I failed to catch that earlier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blog post: interview with MZ
3 participants