Skip to content

Update 2023-07-31-paris-dev-sprint.md #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Update 2023-07-31-paris-dev-sprint.md #170

merged 2 commits into from
Sep 12, 2023

Conversation

GaelVaroquaux
Copy link
Member

@GaelVaroquaux GaelVaroquaux commented Sep 11, 2023

Towards #165

Mostly order names alphabetically

Also change the sum from 33 to 33

Mostly order names alphabetically

Also change the sum from 33 to 33
@welcome
Copy link

welcome bot commented Sep 11, 2023

Thank You Banner

💖 Thanks for opening this pull request! 💖
scikit-learn community really appreciates your time and effort to contribute to the project.
Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.

@reshamas
Copy link
Member

@GaelVaroquaux
First of all, congratulations on your first PR to the blog repo! Thank you for the PR. We hope you enjoyed the Welcome banner!

a small comment:
The blog has a date of 2023-07-31. Can we change it to 2023-09-12 ? or 2023-09-10 ?

@GaelVaroquaux
Copy link
Member Author

GaelVaroquaux commented Sep 11, 2023 via email

@GaelVaroquaux
Copy link
Member Author

Sure! Shall I do this in this PR?

Date change done

@reshamas
Copy link
Member

Sure! Shall I do this in this PR?

Date change done

I thought the actual file name needed to be changed. But, maybe not?

@reshamas
Copy link
Member

I'll merge it in and see what the date shows.

@reshamas reshamas merged commit e3a7293 into main Sep 12, 2023
@welcome
Copy link

welcome bot commented Sep 12, 2023

Congratulations Banner

Congrats on merging your first pull request! 🎉
We here at scikit-learn are proud of you! 💖
Thank you so much for your contribution 🎁

@GaelVaroquaux
Copy link
Member Author

GaelVaroquaux commented Sep 12, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants