Skip to content

[MRG+1] Fixes #10571: Shape of coef_ wrong for linear_model.Lasso when using `fit_interce… #10687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 27, 2018
Merged

[MRG+1] Fixes #10571: Shape of coef_ wrong for linear_model.Lasso when using `fit_interce… #10687

merged 5 commits into from
Feb 27, 2018

Conversation

martin-hahn
Copy link
Contributor

@martin-hahn martin-hahn commented Feb 24, 2018 •
edited by jnothman
Loading

Reference Issues/PRs

Fixes #10571
Resolves #10616
Shape of coef_ wrong for linear_model.Lasso when using fit_intercept=False

What does this implement/fix? Explain your changes.

np.squeeze was misused and returned zero shaped arrays.

@martin-hahn
Copy link
Contributor Author

I think the failure on circleci is a false positive alarm. Perhaps someone with permissions can rerun it.

jnothman
jnothman approved these changes Feb 25, 2018
View reviewed changes
Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jnothman
jnothman approved these changes Feb 25, 2018
View reviewed changes
Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnothman jnothman changed the title [MRG] Fixes #10571: Shape of coef_ wrong for linear_model.Lasso when using `fit_interce… [MRG+1] Fixes #10571: Shape of coef_ wrong for linear_model.Lasso when using `fit_interce… Feb 25, 2018
@jnothman
Copy link
Member

Please add an entry to the change log at doc/whats_new/v0.20.rst. Like the other entries there, please reference this pull request with :issue: and credit yourself (and other contributors if applicable) with :user:

@jnothman
Copy link
Member

Although there's another PR at #10616

@jnothman jnothman merged commit da71b82 into scikit-learn:master Feb 27, 2018
@jnothman
Copy link
Member

Thanks @martin-hahn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@agramfort agramfort agramfort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shape of coef_ wrong for linear_model.Lasso when using fit_intercept=False
3 participants
@martin-hahn @jnothman @agramfort