Skip to content

Elastic Net Sparse co-ordinate descent doesn't take the maxium of the absolute value of the weight #10992

Closed
@Craigacp

Description

@Craigacp

In cd_fast.pyx, the function sparse_enet_coordinate_descent at lines 483 & 484 doesn't take the absolute value of the weight to check the max, it uses the signed value. This means it will ignore negative updates, and probably trigger the duality gap check more frequently than it should. Looking at lines 270 and 271 of enet_coordinate_descent the absolute value of the weight is used.

I think this is a replica of issue #283, which was fixed many years ago in enet_coordinate_descent, enet_coordinate_descent_gram and enet_coordinate_descent_multi_task.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions