Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add n_jobs to make_union #8028

Closed
amueller opened this issue Dec 9, 2016 · 2 comments
Closed

add n_jobs to make_union #8028

amueller opened this issue Dec 9, 2016 · 2 comments
Labels

Comments

@amueller
Copy link
Member

@amueller amueller commented Dec 9, 2016

make_union currenlty has a comment saying "it would be nice to add a keyword-only n_jobs but that's not allowed in Python 2.x".

That's bogus as far as I can tell and we can easily add **kwargs there.

@jnothman
Copy link
Member

@jnothman jnothman commented Dec 11, 2016

I wonder whether that comment derived from a precursor when we were considering make_union(name=estimator)

@amueller
Copy link
Member Author

@amueller amueller commented Dec 12, 2016

maybe? Doesn't really matter now, though ;)

@jnothman jnothman closed this Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.