Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add n_jobs to make_union #8028

Closed
amueller opened this issue Dec 9, 2016 · 2 comments
Closed

add n_jobs to make_union #8028

amueller opened this issue Dec 9, 2016 · 2 comments
Labels
Easy Well-defined and straightforward way to resolve

Comments

@amueller
Copy link
Member

amueller commented Dec 9, 2016

make_union currenlty has a comment saying "it would be nice to add a keyword-only n_jobs but that's not allowed in Python 2.x".

That's bogus as far as I can tell and we can easily add **kwargs there.
@amueller amueller added Easy Well-defined and straightforward way to resolve Need Contributor labels Dec 9, 2016
@alexandercbooth alexandercbooth mentioned this issue Dec 10, 2016
Merged
@jnothman
Copy link
Member

jnothman commented Dec 11, 2016 •
edited
Loading

I wonder whether that comment derived from a precursor when we were considering make_union(name=estimator)

@amueller
Copy link
Member Author

maybe? Doesn't really matter now, though ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Well-defined and straightforward way to resolve
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jnothman @amueller