Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LogisticregressionCV doesn't document shape of C_ properly #8424

Closed
amueller opened this issue Feb 21, 2017 · 1 comment · Fixed by #8434
Closed

LogisticregressionCV doesn't document shape of C_ properly #8424

amueller opened this issue Feb 21, 2017 · 1 comment · Fixed by #8434
Labels
Documentation Easy Well-defined and straightforward way to resolve

Comments

@amueller
Copy link
Member

http://scikit-learn.org/dev/modules/generated/sklearn.linear_model.LogisticRegressionCV.html#sklearn.linear_model.LogisticRegressionCV

says

C_ : array, shape (n_classes,) or (n_classes - 1,)

    Array of C that maps to the best scores across every class. If refit is set to False, then for each class, the best C is the average of the C’s that correspond to the best scores for each fold.

but it doesn't say when it would be either shape. I think it should.
@amueller amueller added Documentation Easy Well-defined and straightforward way to resolve Need Contributor labels Feb 21, 2017
@aashil
Copy link
Contributor

aashil commented Feb 21, 2017

I would like to work on this one.

abhyudaypratap added a commit to abhyudaypratap/scikit-learn that referenced this issue Feb 22, 2017
@abhyudaypratap
LogisticregressionCV docs(scikit-learn#8424): documented C_ shape
9b83da6
@abhyudaypratap abhyudaypratap mentioned this issue Feb 22, 2017
Merged
abhyudaypratap added a commit to abhyudaypratap/scikit-learn that referenced this issue Feb 22, 2017
@abhyudaypratap
LogisticregressionCV docs(scikit-learn#8424): documented C_ shape
04fe565
abhyudaypratap added a commit to abhyudaypratap/scikit-learn that referenced this issue Feb 22, 2017
@abhyudaypratap
LogisticregressionCV docs(scikit-learn#8424): documented C_ shape
ce82580
abhyudaypratap added a commit to abhyudaypratap/scikit-learn that referenced this issue Feb 22, 2017
@abhyudaypratap
LogisticregressionCV docs(scikit-learn#8424): documented C_ shape
6688461
abhyudaypratap added a commit to abhyudaypratap/scikit-learn that referenced this issue Feb 22, 2017
@abhyudaypratap
LogisticregressionCV docs(scikit-learn#8424): documented C_ shape
6dea62e
GaelVaroquaux pushed a commit that referenced this issue Jun 7, 2017
@abhyudaypratap @GaelVaroquaux
LogisticregressionCV docs(#8424): documented C_ shape (#8434)
ccff672
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this issue Jun 14, 2017
@abhyudaypratap @Sundrique
LogisticregressionCV docs(scikit-learn#8424): documented C_ shape (sc…
d7e7715 
…ikit-learn#8434)
dmohns pushed a commit to dmohns/scikit-learn that referenced this issue Aug 7, 2017
@abhyudaypratap @dmohns
LogisticregressionCV docs(scikit-learn#8424): documented C_ shape (sc…
7d02feb 
…ikit-learn#8434)
dmohns pushed a commit to dmohns/scikit-learn that referenced this issue Aug 7, 2017
@abhyudaypratap @dmohns
LogisticregressionCV docs(scikit-learn#8424): documented C_ shape (sc…
ff1813d 
…ikit-learn#8434)
NelleV pushed a commit to NelleV/scikit-learn that referenced this issue Aug 11, 2017
@abhyudaypratap @NelleV
LogisticregressionCV docs(scikit-learn#8424): documented C_ shape (sc…
b90f3ba 
…ikit-learn#8434)
paulha pushed a commit to paulha/scikit-learn that referenced this issue Aug 19, 2017
@abhyudaypratap @paulha
LogisticregressionCV docs(scikit-learn#8424): documented C_ shape (sc…
6e3aa71 
…ikit-learn#8434)
AishwaryaRK pushed a commit to AishwaryaRK/scikit-learn that referenced this issue Aug 29, 2017
@abhyudaypratap @AishwaryaRK
LogisticregressionCV docs(scikit-learn#8424): documented C_ shape (sc…
bcb9ee4 
…ikit-learn#8434)
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this issue Nov 15, 2017
@abhyudaypratap @maskani-moh
LogisticregressionCV docs(scikit-learn#8424): documented C_ shape (sc…
b35385f 
…ikit-learn#8434)
jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this issue Dec 18, 2017
@abhyudaypratap
LogisticregressionCV docs(scikit-learn#8424): documented C_ shape (sc…
6e7b288 
…ikit-learn#8434)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Easy Well-defined and straightforward way to resolve
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG] LogisticregressionCV docs(#8424): documented C_ shape abhyudaypratap/scikit-learn
2 participants
@amueller @aashil