[MRG+1] Improve example plot_label_propagation_structure.py #9788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, makes sense. LGTM. But to double-check, please review @musically-ut? |
jnothman
changed the title
|
LGTM, too. I wonder if there are any other examples which are effected by the |
|
At a glance, other semi supervised examples seems to be fine (though the result may be different bacause of the bug fix in 0.19). |
|
Good catch @qinhanmin2014, LGTM, merging! |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Oct 3, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
What does this implement/fix? Explain your changes.
The example looks good in 0.18 (except for the title)
But looks strange in 0.19
new version from Circle CI:
Any other comments?