-
-
Notifications
You must be signed in to change notification settings - Fork 26.2k
[MRG] MNT DOC Fix the single backtick issues #13542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This should substantially reduce the warnings. I'll leave the ones not addressed here for another PR, already kinda touching quite a few files here. I've gone through the changes once manually, and fixed the long line issues, shouldn't be too far from an acceptable one. @thomasjpfan wanna have a look? |
This is not the point imo. We want to be able to use single backticks for code formatting |
Then the question is do we warn on an unresolved one or not. First the answer was no (what @thomasjpfan had), and then we talked about it and it didn't seem like a good idea to not warn on them, cause sometimes that's just a typo and it should be fixed, or it's the wrong address or whatever. To get those warnings, the warnings were enabled, but we decided to fix the single backticks which result in warnings later. |
The single backticks is doing too much, since we set the default role to |
I like this alternative too, but this also means a whole bunch of links in our docs will become simple code. |
I think it's really nice not having to be explicit, as it gets in the way
of readability for things like class names, but I'm okay with it (i.e
default_role = code)
|
@thomasjpfan should we (i.e. you :D, I'm not sure how you did that magic) again revert to ignoring these warnings and considering them code then? |
@adrinjalali I’ll remove the warnings. We should also add |
There are only a few glossary references. But there are 278 resolved references to python functions/classes. Adding From what I recall from the sprint, the biggest concern was as follows: when someone wants to reference something but misspelled so it turns into code. Since adding With this, I propose we keep what we have now on master and remove the warnings we currently have for unresolved references. |
Misspellings are great. They help people contribute ;)
|
This is to fix the
WARNING: 'any' reference target not found
issues while making the documentation.