Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Bin training and validation data separately in GBDTs #13933

Merged
merged 7 commits into from May 28, 2019

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented May 23, 2019

Closes #13926

Instead of binning the whole data before the train/validation split, we now bin the training and validation data separately.

Not sure if that's worth a whatsnew entry, since it's all experimental still?

Copy link
Member

@ogrisel ogrisel left a comment

LGTM, thanks!

@ogrisel
Copy link
Member

@ogrisel ogrisel commented May 23, 2019

Not sure if that's worth a whatsnew entry, since it's all experimental still?

Maybe we can have a compound entry that summaries all the small changes to HistGradientBoosting*.

@NicolasHug
Copy link
Member Author

@NicolasHug NicolasHug commented May 23, 2019

I added a regular whatsnew entry, we can make the compound entry when there's more to add

@ogrisel
Copy link
Member

@ogrisel ogrisel commented May 24, 2019

@thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented May 25, 2019

Should the _BinMapper that was fitted on the training data be used to transform the validation data?

@NicolasHug
Copy link
Member Author

@NicolasHug NicolasHug commented May 26, 2019

Yes, good point

Copy link
Member

@thomasjpfan thomasjpfan left a comment

LGTM

@thomasjpfan thomasjpfan changed the title [MRG] bin training and validation data separately in GBDTs FIX Bin training and validation data separately in GBDTs May 28, 2019
@thomasjpfan thomasjpfan merged commit 2a7194d into scikit-learn:master May 28, 2019
16 checks passed
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this issue Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants