Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Bin training and validation data separately in GBDTs #13933

Merged
merged 7 commits into from May 28, 2019

Conversation

@NicolasHug
Copy link
Contributor

NicolasHug commented May 23, 2019

Closes #13926

Instead of binning the whole data before the train/validation split, we now bin the training and validation data separately.

Not sure if that's worth a whatsnew entry, since it's all experimental still?

Copy link
Member

ogrisel left a comment

LGTM, thanks!

@ogrisel

This comment has been minimized.

Copy link
Member

ogrisel commented May 23, 2019

Not sure if that's worth a whatsnew entry, since it's all experimental still?

Maybe we can have a compound entry that summaries all the small changes to HistGradientBoosting*.

@NicolasHug

This comment has been minimized.

Copy link
Contributor Author

NicolasHug commented May 23, 2019

I added a regular whatsnew entry, we can make the compound entry when there's more to add

@ogrisel

This comment has been minimized.

Copy link
Member

ogrisel commented May 24, 2019

…n_train_val_separately
@thomasjpfan

This comment has been minimized.

Copy link
Member

thomasjpfan commented May 25, 2019

Should the _BinMapper that was fitted on the training data be used to transform the validation data?

@NicolasHug

This comment has been minimized.

Copy link
Contributor Author

NicolasHug commented May 26, 2019

Yes, good point

Copy link
Member

thomasjpfan left a comment

LGTM

@thomasjpfan thomasjpfan changed the title [MRG] bin training and validation data separately in GBDTs FIX Bin training and validation data separately in GBDTs May 28, 2019
@thomasjpfan thomasjpfan merged commit 2a7194d into scikit-learn:master May 28, 2019
16 checks passed
16 checks passed
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: doc Your tests passed on CircleCI!
Details
ci/circleci: doc-min-dependencies Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.84%)
Details
codecov/project 96.84% (+<.01%) compared to e747376
Details
scikit-learn.scikit-learn Build #20190527.32 succeeded
Details
scikit-learn.scikit-learn (Linux py35_conda_openblas) Linux py35_conda_openblas succeeded
Details
scikit-learn.scikit-learn (Linux py35_np_atlas) Linux py35_np_atlas succeeded
Details
scikit-learn.scikit-learn (Linux pylatest_conda) Linux pylatest_conda succeeded
Details
scikit-learn.scikit-learn (Windows py35_32) Windows py35_32 succeeded
Details
scikit-learn.scikit-learn (Windows py37_64) Windows py37_64 succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda) macOS pylatest_conda succeeded
Details
koenvandevelde added a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.