Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] API Deprecates probA_ and probB_ in OneClassSVM and svm.SVR #15558

merged 12 commits into from Jan 28, 2020


Copy link

Reference Issues/PRs

Fixes #14781

What does this implement/fix? Explain your changes.

Requires deprecation cycle.

Any other comments?

doc/whats_new/v0.22.rst Outdated Show resolved Hide resolved
@thomasjpfan thomasjpfan changed the title API Deprecates probA_ and probB_ in OneClassSVM and svm.SVR. [MRG] API Deprecates probA_ and probB_ in OneClassSVM and svm.SVR Dec 3, 2019
Copy link

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these attributes are not documented, I wonder if a deprecation cycle is necessary, but I'm fine with that. Lgtm !

@thomasjpfan Please resolve the conflicts and feel free to merge.

@jeremiedbb jeremiedbb merged commit 8ea05cb into scikit-learn:master Jan 28, 2020
Copy link

Thanks @thomasjpfan !

thomasjpfan added a commit to thomasjpfan/scikit-learn that referenced this pull request Feb 22, 2020
panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

SVR inherited attributes: probB / probA
3 participants