-
-
Notifications
You must be signed in to change notification settings - Fork 26.2k
Add a optional fit_param to enable custom MultiOutput fit process #15959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a optional fit_param to enable custom MultiOutput fit process #15959
Conversation
Be aware that we don't want to have any tight with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of changes. We also need a what's new entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you could just parametrize the test as below. Otherwise, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. ping @thomasjpfan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @huangk10 !
Reference Issues/PRs
See also #15953
What does this implement/fix? Explain your changes.
This allows the
MultiOutputRegressor.fit
to accept a**fit_params
to custom estimator fit process.Example:
Any other comments?
To custom some of the estimators' fit processes, we have to redifine the
estimators.fit
functions with customed paramters besidessample_weight
. Beacause thefit
methods of most defined estimators in thesklearn
package just have asample_weight
parameter.