Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argument validation in make_multilabel_classification() #16006

Merged
merged 9 commits into from Jan 4, 2020
Merged

Argument validation in make_multilabel_classification() #16006

merged 9 commits into from Jan 4, 2020

Conversation

rushabh-v
Copy link
Contributor

Fixes #16001

glemaitre
glemaitre requested changes Jan 3, 2020
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add an entry in what's new as well

sklearn/datasets/_samples_generator.py Outdated Show resolved Hide resolved
sklearn/datasets/_samples_generator.py Outdated Show resolved Hide resolved
sklearn/datasets/_samples_generator.py Outdated Show resolved Hide resolved
sklearn/datasets/_samples_generator.py Outdated Show resolved Hide resolved
sklearn/datasets/_samples_generator.py Outdated Show resolved Hide resolved
sklearn/datasets/tests/test_samples_generator.py Outdated Show resolved Hide resolved
@glemaitre
Copy link
Member

CIs are failing due to linting. Can you add a what's new entry.

@rushabh-v
Copy link
Contributor Author

test_spectral_embedding_amg_solver_failure fails on Linux pylatest_pip_openblas_pandas due to these changes.

@rushabh-v
Copy link
Contributor Author

test_spectral_embedding_amg_solver_failure fails on Linux pylatest_pip_openblas_pandas due to these changes.

Couldn't find out ant reason for it only failing on pylatest_pip_openblas_pandas. Any clues?

thomasjpfan
thomasjpfan approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan
Copy link
Member

test_spectral_embedding_amg_solver_failure will be fixed when #16014 is merged.

glemaitre
glemaitre approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ogrisel ogrisel merged commit 11147a1 into scikit-learn:master Jan 4, 2020
@ogrisel
Copy link
Member

ogrisel commented Jan 4, 2020

Merged, thanks @rushabh-v!

@rushabh-v rushabh-v deleted the patch-2 branch January 4, 2020 19:38
panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020
@rushabh-v
Argument validation in make_multilabel_classification() (scikit-learn…
9378346 
…#16006)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible infinite loop iterations in synthetic data sets generation module
4 participants
@rushabh-v @glemaitre @thomasjpfan @ogrisel