Skip to content

Argument validation in make_multilabel_classification() - #16006

Merged
ogrisel merged 9 commits into
scikit-learn:masterfrom
rushabh-v:patch-2
Jan 4, 2020
Merged

ogrisel merged 9 commits into
scikit-learn:masterfrom
rushabh-v:patch-2

Conversation

@rushabh-v

Copy link
Copy Markdown
Contributor

Fixes #16001

@glemaitre glemaitre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add an entry in what's new as well

Comment thread sklearn/datasets/_samples_generator.py Outdated
Comment thread sklearn/datasets/_samples_generator.py Outdated
Comment thread sklearn/datasets/_samples_generator.py Outdated
Comment thread sklearn/datasets/_samples_generator.py Outdated
Comment thread sklearn/datasets/_samples_generator.py Outdated
Comment thread sklearn/datasets/tests/test_samples_generator.py Outdated
@glemaitre

Copy link
Copy Markdown
Member

CIs are failing due to linting. Can you add a what's new entry.

@rushabh-v

Copy link
Copy Markdown
Contributor Author

test_spectral_embedding_amg_solver_failure fails on Linux pylatest_pip_openblas_pandas due to these changes.

@rushabh-v

Copy link
Copy Markdown
Contributor Author

test_spectral_embedding_amg_solver_failure fails on Linux pylatest_pip_openblas_pandas due to these changes.

Couldn't find out ant reason for it only failing on pylatest_pip_openblas_pandas. Any clues?

@thomasjpfan thomasjpfan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan

Copy link
Copy Markdown
Member

test_spectral_embedding_amg_solver_failure will be fixed when #16014 is merged.

@glemaitre glemaitre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ogrisel
ogrisel merged commit 11147a1 into scikit-learn:master Jan 4, 2020
@ogrisel

ogrisel commented Jan 4, 2020

Copy link
Copy Markdown
Member

Merged, thanks @rushabh-v!

@rushabh-v
rushabh-v deleted the patch-2 branch January 4, 2020 19:38
panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible infinite loop iterations in synthetic data sets generation module

4 participants