Fix: Possible unnecessary iterations in Newton-CG algorithm #16266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rth
approved these changes
Jan 29, 2020
There was a problem hiding this comment.
Thanks @rushabh-v, LGTM!
I think we can probably accept this without a regression test, since the fix is trivial and I don't see an obvious way to test it.
|
I would still add an entry in what's new thought mentioning that we will check for inferior or equal instead of strictly inferior. |
|
I have added the whatsnew |
glemaitre
reviewed
Jan 29, 2020
Co-Authored-By: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-Authored-By: Guillaume Lemaitre <g.lemaitre58@gmail.com>
jnothman
reviewed
Jan 29, 2020
jnothman
reviewed
Jan 30, 2020
doc/whats_new/v0.23.rst
Outdated
| @@ -197,6 +197,11 @@ Changelog | |||
|
|
|||
| - |Enhancement| improve error message in :func:`utils.validation.column_or_1d`. | |||
| :pr:`15926` by :user:`Loïc Estève <lesteve>`. | |||
|
|
|||
| - |Fix| `optimize._newton_cg` will now avoid an unnecessary iteration by checking for | |||
There was a problem hiding this comment.
We also need to focus on public API in what's new. This is private. What public API did this affect?
There was a problem hiding this comment.
It affects LogisticRegression when arg solver=newton-cg. I am adding it in whatsnew
There was a problem hiding this comment.
done. Tell me if any change is required...
jnothman
approved these changes
Jan 31, 2020
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 22, 2020
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16186