MNT Change print_changed_only default to True#17061
Merged
NicolasHug merged 10 commits intoApr 27, 2020
Merged
Conversation
NicolasHug
changed the title
NicolasHug
commented
Apr 27, 2020
rth
approved these changes
Apr 27, 2020
rth
left a comment
rth
left a comment
Member
There was a problem hiding this comment.
Thanks! I think it would be nice to have in this release!
ogrisel
approved these changes
Apr 27, 2020
Member
Author
|
Thanks for the reviews! I addressed the comments Maybe we should wait for @jnothman before merging since I believe he had some comments about this |
…anged_only_default
thomasjpfan
approved these changes
Apr 27, 2020
thomasjpfan
left a comment
thomasjpfan
left a comment
Member
There was a problem hiding this comment.
I am happy with the code quality. I agree we should wait for @jnothman
jnothman
approved these changes
Apr 27, 2020
| printing an estimator. You can restore the previous behaviour by using | ||
| `sklearn.set_config(print_changed_only=False)`. Also, note that it is | ||
| always possible to quickly inspect the parameters of any estimator using | ||
| `est.get_params()`. :pr:`17061` by `Nicolas Hug`_. |
Member
There was a problem hiding this comment.
Yes, I was looking to see if you had these docs. Nicely done. I'd consider noting deep=False to not overwhelm uses.
Member
Author
|
Thanks all for the reviews, merging |
NicolasHug
changed the title
Member
Author
|
ping #17010 |
adrinjalali
pushed a commit
that referenced
this pull request
Apr 30, 2020
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
santisoler
added a commit
to fatiando/verde
that referenced
this pull request
Jun 3, 2020
Change the expected representation of any gridder based on the new default behaviour of Scikit Learn. After 0.23, Scikit Learn only shows those parameters whose default value has been changed when giving a string representation of the gridder. See scikit-learn/scikit-learn#17061 and its changelog for more information. Fix #266
6 tasks
santisoler
added a commit
to fatiando/verde
that referenced
this pull request
Jun 3, 2020
Change the expected representation of any gridder based on the new default behaviour of Scikit Learn. After 0.23, Scikit Learn only shows those parameters whose default value has been changed when giving a string representation of the gridder. See scikit-learn/scikit-learn#17061 and its changelog for more information.
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes
print_changed_only=Trueas the defaultWould be nice in 0.23 but not a priority either
CC @jnothman @adrinjalali @thomasjpfan @amueller @glemaitre