-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
BUG Validate transformers in transform #17360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG Validate transformers in transform #17360
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
ping @rth @jeremiedbb @NicolasHug This is an easy hanging fruit. |
ping @adrinjalali I saw is around as well :) |
Should this also have a what's new entry? |
True since this is a FIX |
Note this PR targets the Looking back at this, I think this will introduce a bug for users that want to construct a prefitted |
Oh, yhis is why I prefer to remove the deprecations much closer to the next major release rather than right after a release. In this case, we can keep this PR open and add it to the minor release milestone, have a separate PR which adds the whats_new entry to master and backport it to the release branch at the time of the release, and merge this one right before we'd like to release I suppose. |
ping @adrinjalali :P |
I'm not sure what I'm pinged for @glemaitre :P I'm happy to have this merged right before we do the next minor release. We also need the separate PR for the changelog to the master branch. I'm also happy if we do a minor release in a week. There's a ton of documentation improvement which we could improve in the release, and a few fixes, but I guess not too many. |
I think this is the last flagged PR for 0.23.2. I merged a fix for the StackingEstimator which should also go in 0.23.2. |
This PR has to be merged independent of the other ones which will go to the release PR since it targets the release branch directly and not the master branch. So I'd say if you wanna do a release, prepare that PR, and close to the release merge this one and that one? And again, remember the changelog entry ;) |
The whats new update is at #17912 |
Fixes #17355