FIX Fix handling of binary_only tag in check_estimator#17812
Merged
Conversation
brcharron
force-pushed
the
fix_binary_only
branch
from
15edf2e to
522ed74
Compare
rth
approved these changes
Jul 4, 2020
rth
left a comment
rth
left a comment
Member
There was a problem hiding this comment.
Very nice, thank you @brcharron !
jnothman
approved these changes
Jul 5, 2020
jnothman
left a comment
jnothman
left a comment
Member
There was a problem hiding this comment.
Neat! This may deserve a what's new entry? Not sure
thomasjpfan
approved these changes
Jul 5, 2020
thomasjpfan
left a comment
thomasjpfan
left a comment
Member
There was a problem hiding this comment.
I think this change is big enough to be added to whats new:
Please add an entry to the change log at doc/whats_new/v0.24.rst with tag |Fix|. Like the other entries there, please reference this pull request with :pr: and credit yourself (and other contributors if applicable) with :user:.
brcharron
added a commit
to brcharron/scikit-learn
that referenced
this pull request
Jul 6, 2020
brcharron
force-pushed
the
fix_binary_only
branch
from
8fece24 to
524717d
Compare
Contributor
Author
|
Thanks for the reviews! I added an entry to the What's New page. |
thomasjpfan
changed the title
Member
|
Thank you @brcharron ! |
|
Thanks @brcharron 🎉 |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 3, 2020
…17812) Co-authored-by: Bruno Charron <bruno@charron.email>
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
…17812) Co-authored-by: Bruno Charron <bruno@charron.email>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #16798
What does this implement/fix? Explain your changes.
Some checks in
check_estimatorwere generating test cases with more than 2 classes regardless of whether thebinary_onlytag was provided by the estimator. Fixed these checks so they only generate test cases with up to 2 classes. Also simplified other tests which had special behavior for thebinary_onlytag by leveraging_enforce_estimator_tags_y. Changed the test to useSGDClassiferas it has a apartial_fitmethod which did not pass the existing test.Any other comments?