/ scikit-learn Public
FIX Fix handling of binary_only tag in check_estimator #17812
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
What does this implement/fix? Explain your changes.
Some checks in
check_estimatorwere generating test cases with more than 2 classes regardless of whether the
binary_onlytag was provided by the estimator. Fixed these checks so they only generate test cases with up to 2 classes. Also simplified other tests which had special behavior for the
binary_onlytag by leveraging
_enforce_estimator_tags_y. Changed the test to use
SGDClassiferas it has a a
partial_fitmethod which did not pass the existing test.
Any other comments?