ENH add parameter as_frame in fetch_kddcup99 #18280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
reviewed
Aug 29, 2020
| def test_OSError_message(fetch_kddcup99_fxt): | ||
| expected_msg = ('Download kddcup99 to run this test') | ||
| with pytest.raises(OSError, match=expected_msg): | ||
| fetch_kddcup99_fxt(data_home="./", download_if_missing=False) |
There was a problem hiding this comment.
Is this testing code in conftest?
There was a problem hiding this comment.
True. I was not aware of it.
| dataset_shuffled = fetch_kddcup99_fxt( | ||
| random_state=0, subset='SA', shuffle=True, percent10=True, | ||
| ) | ||
| assert any(dataset_shuffled.target[-100:] == b'normal.') |
There was a problem hiding this comment.
If this is testing shuffle should we do:
assert set(dataset['target']) == set(dataset_shuffle['target'])There was a problem hiding this comment.
yes this is less error-prone even if we added the random state.
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
Co-authored-by: aliang <aliang@air>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Supersede and closes #17508
Add parameter
as_frametofetch_kddcup99.