Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Do not call get_feature_names for empty column selections #19579

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Fixes #19550

Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

@ogrisel ogrisel added this to the 0.24.2 milestone Feb 27, 2021
@ogrisel ogrisel merged commit 15c2c72 into scikit-learn:main Feb 27, 2021
@cmarmo cmarmo added the To backport PR merged in master that need a backport to a release branch defined based on the milestone. label Apr 6, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:compose To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ColumnTransformer treats empty arrays differently depending on their representation
4 participants