FIX deprecate sample_weight in predict method of BaseKMeans #25251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevv
changed the title
glevv
changed the title
jeremiedbb
reviewed
Dec 30, 2022
There was a problem hiding this comment.
Thanks for the PR @glevv. Looks good. I think you can switch this PR to ready.
jjerphan
approved these changes
Jan 2, 2023
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan
added a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 3, 2023
…earn#25251) Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Fixes scikit-learn#25066
jpangas
pushed a commit
to jpangas/scikit-learn
that referenced
this pull request
Jan 4, 2023
…earn#25251) Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Fixes scikit-learn#25066
jjerphan
added a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
…earn#25251) Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Fixes scikit-learn#25066
jjerphan
added a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
…earn#25251) Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #25066
What does this implement/fix? Explain your changes.
Deprecation of
sample_weightparameter inpredictmethod for KMeans