Skip to content

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented May 31, 2023

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Starting from Python 3.3, EnvironmentError, IOError and WindowsError are aliases of OSError:
https://docs.python.org/3/library/exceptions.html#IOError

Any other comments?

@DimitriPapadopoulos DimitriPapadopoulos changed the title CLN IOError → OSError CLN EnvironmentError, IOError, WindowsError → OSError May 31, 2023
@DimitriPapadopoulos DimitriPapadopoulos changed the title CLN EnvironmentError, IOError, WindowsError → OSError [MRG] EnvironmentError, IOError, WindowsError → OSError May 31, 2023
@DimitriPapadopoulos DimitriPapadopoulos changed the title [MRG] EnvironmentError, IOError, WindowsError → OSError CLN EnvironmentError, IOError, WindowsError → OSError May 31, 2023
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@adrinjalali adrinjalali added Quick Review For PRs that are quick to review Waiting for Second Reviewer First reviewer is done, need a second one! labels Jun 1, 2023
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 4509e58 into scikit-learn:main Jun 2, 2023
@DimitriPapadopoulos DimitriPapadopoulos deleted the IOError branch June 2, 2023 21:22
manudarmi pushed a commit to primait/scikit-learn that referenced this pull request Jun 12, 2023
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:datasets Quick Review For PRs that are quick to review Waiting for Second Reviewer First reviewer is done, need a second one!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants