Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Allow alpha 0 when not using LOO in RidgeCV #28425

Merged
merged 5 commits into from
Feb 17, 2024

Conversation

lucyleeow
Copy link
Member

Reference Issues/PRs

closes #23074

What does this implement/fix? Explain your changes.

Allow alpha 0 when not using default cv LOO, consistent with what happens when you use Ridge and GridSearchCV
Adds note in user guide about this.

Any other comments?

Happy to change.

Copy link

github-actions bot commented Feb 15, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: d4df6d0. Link to the linter CI: here

@lucyleeow
Copy link
Member Author

ping @lorentzenchr

sklearn/linear_model/_ridge.py Outdated Show resolved Hide resolved
sklearn/linear_model/_ridge.py Outdated Show resolved Hide resolved
@lorentzenchr lorentzenchr enabled auto-merge (squash) February 17, 2024 11:08
@lorentzenchr lorentzenchr merged commit aaf215c into scikit-learn:main Feb 17, 2024
28 checks passed
@lucyleeow lucyleeow deleted the ridgecv branch February 19, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RidgeCV doesn't allow alpha=0
2 participants