Simplify estimate gaussian covariances diag#30414
Merged
OmarManzoor merged 2 commits intoscikit-learn:mainfrom Dec 6, 2024
Merged
Simplify estimate gaussian covariances diag#30414OmarManzoor merged 2 commits intoscikit-learn:mainfrom
OmarManzoor merged 2 commits intoscikit-learn:mainfrom
Conversation
ogrisel
force-pushed
the
simplify-_estimate_gaussian_covariances_diag
branch
from
553fc3d to
67c180d
Compare
jeremiedbb
approved these changes
Dec 5, 2024
Member
jeremiedbb
left a comment
jeremiedbb
left a comment
There was a problem hiding this comment.
LGTM.
For future reviewers, the means arg receives means computed as means = np.dot(resp.T, X) / nk[:, np.newaxis], so avg_X_means is precisely means**2.
Member
|
Not sure it requires a changelog entry since it's internal detail but now that it's here. |
ogrisel
force-pushed
the
simplify-_estimate_gaussian_covariances_diag
branch
from
67c180d to
f31c5dd
Compare
Member
Author
|
@mekleo I amended my commit to credit co-authorship (and similarly in the changelog entry). Please let us know if this is fine with you. |
Contributor
Great, thank you Olivier. Thanks, Jeremie for the speedy review. |
virchan
pushed a commit
to virchan/scikit-learn
that referenced
this pull request
Dec 9, 2024
Co-authored-by: mekleo <36504477+mekleo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quick efficiency improvement spotted by @mekleo in #30382.
I think this can go in independently of the decided resolution of the numerical stability problem reported in #30382.