FIX change FutureWarnings to DeprecationWarnings for the tags #30573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fragment name should be |
|
It will be a breaking change between 1.6.0 and 1.6.1 in case people relies on the inheritance of the |
I thought we introduced the warnings after 1.6 but we did it in between the RC and the final release, so all good |
thomasjpfan
approved these changes
Jan 5, 2025
jeremiedbb
approved these changes
Jan 6, 2025
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jan 8, 2025
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jan 8, 2025
jeremiedbb
pushed a commit
that referenced
this pull request
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FutureWarningsthat we raise related to__sklearn_tags__are visible to the end user but without the possibility to fix it because the warnings is more intended to developer of estimators.This PR changes from
FutureWarningstoDeprecationWarnings.