API make murmurhash3_32 private #32103
Merged
+77
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
reviewed
Sep 4, 2025
There was a problem hiding this comment.
Thanks for the PR @FrancoisPgm. Here are some suggestions. Please add a changelog entry and a test for the warning.
Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
…t-learn into murmurhash_deprecation
jeremiedbb
reviewed
Sep 4, 2025
Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
jeremiedbb
reviewed
Sep 4, 2025
Comment on lines
+1
to
+3
| - The function :function:`utils.murmurhash.murmurhash3_32` is now deprecated and will be | ||
| removed in version 1.10. | ||
| By :user:`François Paugam <FrancoisPgm>`. |
There was a problem hiding this comment.
I wonder if we should point users toward another murmurhash3 python wrapper, like https://github.com/hajimes/mmh3, which seems well maintained.
jeremiedbb
approved these changes
Sep 4, 2025
jeremiedbb
added
Waiting for Second Reviewer
ogrisel
approved these changes
Sep 8, 2025
ogrisel
removed
the
Waiting for Second Reviewer
ogrisel
reviewed
Sep 8, 2025
jeremiedbb
added a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Sep 8, 2025
This reverts commit 7f26920.
ogrisel
pushed a commit
that referenced
this pull request
Sep 15, 2025
cakedev0
pushed a commit
to cakedev0/scikit-learn
that referenced
this pull request
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #27593
What does this implement/fix? Explain your changes.
murmurhash3_32is deprecated to a private_murmurhash3_32function.