-
-
Notifications
You must be signed in to change notification settings - Fork 26.3k
FIX estimator HTML repr force dark or light color #32330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This looks good to me, but we do not have infrastructure for automated non-regression testing for this kind of fixes. Setting up some WebDriver based user testing could be a good idea (famous last words) but should better be deferred to a follow-up PR. |
I tested that case and it works as expected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested in VS Code and application that embed the estimator and it works as expected
Actually when not unfolding the inner element, this is fine as in the description so this is another unrelated problem. |
Closes #30357
This PR changes the way color are chosen when displaying an estimator as an HTML representation.
The strategy is the following:
UI previews:
VS code light

VS code dark

VS code dark high crontrast
