RFECV now accepts n_features_to_select parameter #7269
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a test |
| @@ -313,6 +313,11 @@ class RFECV(RFE, MetaEstimatorMixin): | |||
| Defaults to 1 core. If `n_jobs=-1`, then number of jobs is set | |||
| to number of cores. | |||
|
|
|||
| n_features_to_select : int, default=1 | |||
There was a problem hiding this comment.
I think this should be min_n_features, no?
There was a problem hiding this comment.
Does this param dictate exactly how many features are selected, or a minimum?
|
fixed in #11293 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6564.
Does not change any of the logic, simply allows the user to optionally pass in a value for n_features_to_select, rather than hard-coding in the value of 1. Still defaults to 1 if the user does not pass in a value.