Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[MRG+2] Fix #6420 Cloning decision tree estimators breaks criterion objects #7680
What does this implement/fix? Explain your changes.
This fix changes
There was memory management problem, function
Also I added
Any other comments?
referenced this pull request
Oct 16, 2016
Hmm, travis-ci fails with:
I saw this error on local machine (Python 2.7 Ubuntu 16.04), but after
changed the title
[MRG] Fix #6420 Cloning decision tree estimators breaks criterion objects
Oct 19, 2016
Build on one of travis-ci configurations fails with:
I wonder if it's related to my changes. I didn't see this error on travis-ci after first commits, It appeared only when I changed new array creation to .copy(). Is it coincidence? If not - I think I should rewrite
I pulled this PR, and pushed it to my fork. Travis passes smoothly there. The restart build option in travis doesn't clear the cache and retry, which is why this PR is still failing after clearing it's cache :)
I think @olologin needs to force push to rebuild this PR without any cache side effects...
Oh, okay. You're probably right.
On 20 October 2016 at 01:22, Raghav RV firstname.lastname@example.org wrote: