-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Module] add bundle uniformize module #159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there LGTM :)
def prefix = task.ext.prefix ?: "${meta.id}" | ||
def method = task.ext.method ? "--${task.ext.method}" : "--auto" | ||
def swap = task.ext.swap ? "--swap" : "" | ||
def force = task.ext.force ? "-f" : "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mandatory put it in the script
) | ||
} | ||
} | ||
test("bundle - uniformize_axis") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newline here
) | ||
} | ||
} | ||
test("bundle - uniformize_centroid") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
publishDir = { "${params.outdir}/${task.process.tokenize(':')[-1].tokenize('_')[0].toLowerCase()}" } | ||
withName: "BUNDLE_UNIFORMIZE" { | ||
ext.method = "axis x" | ||
ext.force = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove force
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GTG
Describe your changes
Add bundles uniformize module.
List test packages used by your module
tractometry.zip
bundles.zip
Checklist before requesting a review
./modules/nf-scil/<category>/<tool>/main.nf
./modules/nf-scil/<category>/<tool>/meta.yml
./tests/modules/nf-scil/<category>/<tool>/main.nf
./tests/modules/nf-scil/<category>/<tool>/nextflow.config