Adding absolute_peak_values to scil_compute_fodf_metrics.py #715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I added a
absolute_peak_values
option toscil_compute_fodf_metrics.py
, because right now, we return thepeak_values
normalized per voxel and thepeaks
are also multiplied by thesepeak_values
, so we kind of have the information in double. Doing so, we lose any idea of peaks scale between the voxels, since the first peak of each voxel has apeak_value
of 1.What I propose is to save the actual peak amplitudes as
peak_values
and to save thepeaks
(peak_dirs) as unit vectors. This way, we keep a way to compare between voxels, and we can still easily apply thepeak_values
per voxel if we want afterwards.In order to not break any existing pipeline, I put it as an option and kept the legacy way as default.
@CHrlS98 @mdesco @frheault @arnaudbore , I think this concerns you.