Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding absolute_peak_values to scil_compute_fodf_metrics.py #715

Merged
merged 2 commits into from
May 4, 2023

Conversation

karanphil
Copy link
Contributor

Hi, I added a absolute_peak_values option to scil_compute_fodf_metrics.py, because right now, we return the peak_values normalized per voxel and the peaks are also multiplied by these peak_values, so we kind of have the information in double. Doing so, we lose any idea of peaks scale between the voxels, since the first peak of each voxel has a peak_value of 1.

What I propose is to save the actual peak amplitudes as peak_values and to save the peaks (peak_dirs) as unit vectors. This way, we keep a way to compare between voxels, and we can still easily apply the peak_values per voxel if we want afterwards.

In order to not break any existing pipeline, I put it as an option and kept the legacy way as default.

@CHrlS98 @mdesco @frheault @arnaudbore , I think this concerns you.

@arnaudbore arnaudbore self-requested a review April 28, 2023 17:15
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

Copy link
Contributor

@CHrlS98 CHrlS98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add a note in the script description?

scripts/scil_compute_fodf_metrics.py Outdated Show resolved Hide resolved
scripts/scil_compute_fodf_metrics.py Outdated Show resolved Hide resolved
scripts/scil_compute_fodf_metrics.py Outdated Show resolved Hide resolved
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

Copy link
Contributor

@CHrlS98 CHrlS98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@mdesco mdesco merged commit f1d0d06 into scilus:master May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants