Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version and README #759

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Conversation

arnaudbore
Copy link
Contributor

No description provided.

Copy link
Contributor

@AlexVCaron AlexVCaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes for me. Then LGTM

README.md Outdated
⚠️ Breaking changes alert - scilpy 1.6.0 ⚠️

scilpy 1.6.0 is based on [hot_dipy](https://github.com/scilus/hot_dipy) a fork of dipy until dipy release v1.8.0.
In order to install the library and scripts flowlessly (we hope), please follow these instructions:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*flawlessly

README.md Outdated

⚠️ Breaking changes alert - scilpy 1.6.0 ⚠️

scilpy 1.6.0 is based on [hot_dipy](https://github.com/scilus/hot_dipy) a fork of dipy until dipy release v1.8.0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
scilpy 1.6.0 is based on [hot_dipy](https://github.com/scilus/hot_dipy) a fork of dipy until dipy release v1.8.0.
scilpy 1.6.0 is based on [hot_dipy](https://github.com/scilus/hot_dipy) a fork of dipy locked before release v1.8.0.

@arnaudbore
Copy link
Contributor Author

Build passed ! Good Job 🍻 !

@arnaudbore
Copy link
Contributor Author

Build passed ! Good Job 🍻 !

@arnaudbore
Copy link
Contributor Author

Build passed ! Good Job 🍻 !

@arnaudbore arnaudbore merged commit 088910d into scilus:master Oct 5, 2023
5 checks passed
@arnaudbore arnaudbore deleted the release_1.6.0 branch January 30, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants