Easy tests reconst #982
Merged
Easy tests reconst #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #982 +/- ##
==========================================
+ Coverage 68.00% 68.04% +0.03%
==========================================
Files 419 419
Lines 21569 21574 +5
Branches 3242 3244 +2
==========================================
+ Hits 14668 14679 +11
+ Misses 5609 5605 -4
+ Partials 1292 1290 -2
|
karanphil
approved these changes
Apr 23, 2024
scilpy/reconst/fodf.py
Outdated
| # 1000 works well at 2x2x2 = 8 mm3 | ||
| # Hence, we multiply by the volume of a voxel | ||
| vol = (zoom[0] * zoom[1] * zoom[2]) | ||
| if vol != 0: | ||
| max_number_of_voxels = 1000 * 8 // vol | ||
| else: | ||
| max_number_of_voxels = 1000 | ||
| logging.debug("We will search ventricle voxels, up to a maximum of {} " |
There was a problem hiding this comment.
"Searching for ventricle voxels" perhaps? Not a fan of "we will"
scilpy/reconst/frf.py
Outdated
| containing a single fiber population are found using either a threshold on | ||
| the FA, inside a white matter mask. | ||
|
|
||
| Requires |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick description
Took a few minutes today to prepare some unit test in the reconst module.
Coverage of unit test changes (only; no script tests) are:
reconst.fodf: from 0% to 36%reconst.frf: from 0% to 49%Unchanged reconst files:
reconst.aodf= 0% (@CHrlS98 if you want to contribute)!reconst.bingham= 88% (Thanks Charles)reconst.divide, reconst.mti, reconst.sh= 0% (@karanphil if you want to contribute!?)reconst.utils: 36%Type of change
Check the relevant options.
Checklist