Data init #205
Merged
Data init #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Quirks with the way env_file includes files break some of the desired hierarchical loading of the Compose files. If .env.dev is loaded, in general the test results can be invalid.
|
In the process of fixing regressions caught by running the unit tests (Compose "ci" profile), I discovered more problems related the way Compose invludes files specified in the Compose will still load the env vars in Passes the tests as of c5a527f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #203
Description of the Change
The data initialization routine has been refactored heavily, simplifying and further parameterizing locations of data files required by Blast. The integrity of all files is verified using md5sums, allowing the detection of the slightest change to a file or a missing file. The S3-compatible CLI client from MinIO,
mc, was installed in the application image so thatmc mirrorcan be used to pull data in a highly bandwidth and time efficient manner, downloading only the files that are invalid or missing. AFORCE_INITIALIZATIONenv var was added as a convenience to clear the initialization lock files that can sometimes be left on the persistent data volume if initialization fails, typically during code development. A data source page was added to the acknowledgements section of the docs.